fix: use target_compatible_with only for toolchain declarations#126
Open
hunshcn wants to merge 1 commit into
Open
fix: use target_compatible_with only for toolchain declarations#126hunshcn wants to merge 1 commit into
hunshcn wants to merge 1 commit into
Conversation
Contributor
Author
|
@mark-thm ping |
Per discussion in bazel-contrib#104/bazel-contrib#124: - Remove mixed exec+target toolchain registrations - Use target_compatible_with only on toolchain() declarations When the tool is used as an artifact input (rules_oci / pkg_tar), target_compatible_with correctly matches the target platform. When the tool is used as a build tool (cfg="exec"), Bazel sets target_platform = exec_platform in exec config, so target_compatible_with still matches the execution platform. Using exec_compatible_with instead would break the artifact-input case: it would always pick the host architecture regardless of the requested --platforms, which is the original bug. Fixes bazel-contrib#104, Fixes bazel-contrib#124
hunshcn
force-pushed
the
fix-exec-toolchain-only
branch
from
3b4f6b2 to
83e3831
Compare
hunshcn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #104/#124:
target_compatible_withonly ontoolchain()declarationsWhen the tool is used as an artifact input (rules_oci / pkg_tar),
target_compatible_withcorrectly matches the requested target platform.When the tool is used as a build tool (
cfg="exec"), Bazel setstarget_platform = exec_platformin exec config, sotarget_compatible_withstill matches the execution platform.Using
exec_compatible_withinstead would break the artifact-input case: it would always pick the host architecture regardless of the requested--platforms, which is the original bug.Fixes #104, Fixes #124