-
-
Notifications
You must be signed in to change notification settings - Fork 677
Closed
Description
🐞 bug report
Affected Rule
py_binary with --boostrap_impl=script
Is this a regression?
Yes, bootstrap=system_python doesn't have this problem
Originally reported by @scasagrande in #2177
Description
When bootstrap=script is used, it doesn't properly handle when RUNFILES_MANIFEST_FILE is used to find the runfiles directory.
Looking at the code, both code paths that look for *.runfiles/MANIFEST and *.runfiles_manifest might have the same problem.
The fix is to reappend .runfiles to the file name after stripping off the manifest location.
🔬 Minimal Reproduction
To repro, these flags must be set: --enable_runfiles=false --build_runfiles_manifests=true --spawn_strategy=local
It seems that the RUNFILES_MANIFEST_FILE envvar is only set for local executions when runfiles are disabled.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels