[pip_install] ERROR: File "setup.py" not found. Directory cannot be installed in editable mode

[amirh]

🐞 bug report

Affected Rule

The issue is caused by the rule: pip_install

Is this a regression?

No

Description

when using pip_install for a requirements file that has a -e file, pip fails with:
ERROR: File "setup.py" not found. Directory cannot be installed in editable mode.

This happens because pip (executed from here) looks for the setup.py file in the CWD which does not have a setup.py .

Anything else relevant?
#433 fixes this issue as it executes pip from the directory that contains setup.py (confirmed locally that it solved the problem for me).

[groodt]

@amirh Is this now fixed from your perspective since #433 was merged? I'm not sure that bazel can truly support "editable installs" since they would not be hermetic , but at least they should install successfully the first time without error.