fix: allowing to import code generated from proto with strip_import_prefix #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
changed the title
aignas
reviewed
Sep 20, 2023
Collaborator
|
Could you also please a line in the |
run: 'pre-commit run update-deleted-packages -a'
linzhp
added a commit
to linzhp/rules_python
that referenced
this pull request
Oct 15, 2023
…refix (bazel-contrib#1406) When the `proto_library` has `strip_import_prefix`, the py files from proto are generated into a directory like `bazel-bin/tests/py_proto_library/proto/_virtual_imports` and symlinked in the runfiles as `<runfilesroot>/<workspace name>/tests/py_proto_library/proto/_virtual_imports`. We need to add `<workspace name>/tests/py_proto_library/proto/_virtual_imports` to the `imports` of `_PyProtoInfo`, so it will be appended to `PYTHONPATH`. Modified an existing example to demonstrate the scenario and verify the fix. --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
proto_libraryhasstrip_import_prefix, the py files from proto are generated into a directory likebazel-bin/tests/py_proto_library/proto/_virtual_importsand symlinked in the runfiles as<runfilesroot>/<workspace name>/tests/py_proto_library/proto/_virtual_imports.We need to add
<workspace name>/tests/py_proto_library/proto/_virtual_importsto theimportsof_PyProtoInfo, so it will be appended toPYTHONPATH.Modified an existing example to demonstrate the scenario and verify the fix.