fix: py_proto_library: append to PYTHONPATH less #1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only append the `[proto_root]` to PYTHONPATH when it's actually necessary, i.e. when the generated Python modules are under _virtual_imports. Do no append it in the general case, when `[proto_root]` is just the repository root. Fixes bazel-contrib#1551
aignas
reviewed
Nov 13, 2023
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
LGTM, but I would wait for @rickeylev and/or @linzhp to also chime in.
Could you also please add a CHANGELOG.md entry and make the PR description be more like a commit message (which it will become)?
linzhp
approved these changes
Nov 13, 2023
Collaborator
Author
|
I updated the PR description. Re |
aignas
approved these changes
Nov 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only append the
[proto_root]to PYTHONPATH when it's actually necessary, i.e. when the generated Python modules are under _virtual_imports. Do no append it in the general case, when[proto_root]is just the repository root.This makes it much less likely that adding a transitive dep on a
py_proto_librarywill reorder thePYTHONPATH. Such reordering is undesirable because it may lead to import errors.Fixes #1551