Skip to content

test(bzlmod): make the check for hub repo naming less strict #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Feb 15, 2024
Merged

test(bzlmod): make the check for hub repo naming less strict #1757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/bzlmod/libs/my_lib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@

def websockets_is_for_python_version(sanitized_version_check):
# We are checking that the name of the repository folders
# match the expexted generated names. If we update the folder
# structure or naming we will need to modify this test
return f"pip_{sanitized_version_check}_websockets" in websockets.__file__
# match the expected generated names. If we update the folder
# structure or naming we will need to modify this test.
return f"_{sanitized_version_check}_websockets" in websockets.__file__