fix(whl_library): only add group machinery when it is needed#1822
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Mar 27, 2024
Merged
Conversation
This removes the `alias` additions when the package groups are not used fixing alias that attempt to traverse the entire py_library dependency tree. I noticed that for some code that I want to write for `whl_library` having it explicit whether we are using groups or not in the `pip.parse` and or `whl_library` makes the code easier to understand and write. Fixes bazel-contrib#1760
rickeylev
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
aliasadditions when the package groups are not usedfixing alias that attempt to traverse the entire py_library dependency
tree.
I noticed that for some code that I want to write for
whl_libraryhaving it explicit whether we are using groups or not in the
pip.parseand or
whl_librarymakes the code easier to understand and write.Fixes #1760