refactor: use bazel-skylib for creating hub repo aliases#1855
Merged
aignas merged 3 commits intobazel-contrib:mainfrom Apr 29, 2024
Merged
refactor: use bazel-skylib for creating hub repo aliases#1855aignas merged 3 commits intobazel-contrib:mainfrom
aignas merged 3 commits intobazel-contrib:mainfrom
Conversation
With this PR the code becomes more maintainable and easier to inspect. Since bazel-skylib is already a dependency of rules_python, this is a backwards compatible change. Skipping the CHANGELOG notes because it should not be an externally visible change.
philsc
approved these changes
Apr 22, 2024
| name = name, | ||
| actual = render.select( | ||
| selects, | ||
| {tuple(sorted(v, key = lambda x: ("is_python" not in x, x))): k for k, v in sorted(selects.items())}, |
Contributor
There was a problem hiding this comment.
Adding a comment here would be super helpful. It takes a bit of time to understand what this line done.
| selects, | ||
| {tuple(sorted(v, key = lambda x: ("is_python" not in x, x))): k for k, v in sorted(selects.items())}, | ||
| no_match_error = no_match_error, | ||
| key_repr = lambda x: repr(x[0]) if len(x) == 1 else render.tuple(x), |
Contributor
There was a problem hiding this comment.
I'm assuming you're doing this to support the selects.with_or construct from skylib?
EDIT: Okay, pretty clear from looking at the rest of the changes. Might be worth mentioning as a comment here maybe?
rickeylev
approved these changes
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR the code becomes more maintainable and easier to inspect.
Since bazel-skylib is already a dependency of rules_python, this is
a backwards compatible change.
Skipping the CHANGELOG notes because it should not be an externally
visible change.
Work towards #735.