feat(pip_parse): support referencing dependencies to packages via hub#1856
Merged
aignas merged 5 commits intobazel-contrib:mainfrom Apr 30, 2024
Merged
Conversation
With this change we can in theory have multi-platform libraries in the dependency cycle and use the pip hub repo for the dependencies. With this we can also make the contents of `whl_library` not depend on what platform the actual dependencies are. This allows us to support the following topologies: * A platform-specific wheel depends on cross-platform wheel. * A cross-platform wheel depends on cross-platform wheel. * A whl_library can have `select` dependencies based on the interpreter version, e.g. pull in a `tomli` dependency only when the Python interpreter is less than 3.11. Relates to bazel-contrib#1663. Work towards bazel-contrib#735.
Contributor
|
Hmmm gave this a scan and don't have any immediate complaints. While any-any wheels are absolutely my majority use case, I'm a bit concerned about how to model their participation in cycles with platform-dependent artifacts but you've already got that called out as TBD so seems fine. |
philsc
approved these changes
Apr 22, 2024
Contributor
philsc
left a comment
philsc
left a comment
There was a problem hiding this comment.
Looks reasonable. I am admittedly not at all familiar with the existing group_library code, which most of the PR seems concerned with.
rickeylev
approved these changes
Apr 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we can in theory have multi-platform libraries in the
dependency cycle and use the pip hub repo for the dependencies. With
this we can also make the contents of
whl_librarynot depend on whatplatform the actual dependencies are. This allows us to support the
following topologies:
selectdependencies based on the interpreterversion, e.g. pull in a
tomlidependency only when the Pythoninterpreter is less than 3.11.
Relates to #1663.
Work towards #735.