fix: insert user imports before runtime site-packages#2073
Merged
rickeylev merged 9 commits intobazel-contrib:mainfrom Jul 19, 2024
Merged
fix: insert user imports before runtime site-packages#2073rickeylev merged 9 commits intobazel-contrib:mainfrom
rickeylev merged 9 commits intobazel-contrib:mainfrom
Conversation
rickeylev
force-pushed
the
fix.site.packages.sys.path
branch
from
815c43d to
17fc4a8
Compare
aignas
approved these changes
Jul 19, 2024
…o fix.site.packages.sys.path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, all the user import paths were put at the end of sys.path. This was done so that
user import paths didn't hide stdlib modules. However, a side-effect is that user import
paths came after the runtime's site-packages directory. This prevented user imports from
overriding non-stdlib modules included in a runtime (e.g. pip).
To fix, we look for the runtime site-packages directory, then insert the user import paths
before it. A test is used to ensure that the ordering is
[stdlib, user, runtime site-packages]Also fixes a bug introduced by #2076: safe path was being disabled by default
Fixes #2064