chore: cleanup exposed python_repository symbols and add docs#2189
Merged
aignas merged 3 commits intobazel-contrib:mainfrom Sep 6, 2024
Merged
Conversation
The bazel inventory for this sphinxdocs is in bazel-contrib#2188. Removed the things that are definitely not used and the rest of the symbols can be left until we become bzlmod only - they do not require much maintenance.
rickeylev
approved these changes
Sep 6, 2024
Collaborator
rickeylev
left a comment
rickeylev
left a comment
There was a problem hiding this comment.
just the doc comment, otherwise lgtm
python/repositories.bzl
Outdated
| python_register_multi_toolchains = _python_register_multi_toolchains | ||
| python_register_toolchains = _python_register_toolchains | ||
|
|
||
| # Useful for documentation. |
Collaborator
There was a problem hiding this comment.
i.e. not intended to be public? Lets put a more explicit comment saying its only here for documentation, not public consumption, then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bazel inventory for this sphinxdocs is in #2188.
Removed the things that are definitely not used and the rest of the symbols
can be left until we become bzlmod only - they do not require much maintenance.