feat(bzlmod): add python.override APIs#2222
Merged
aignas merged 11 commits intobazel-contrib:mainfrom Sep 22, 2024
Merged
Conversation
Before this PR the users could not override how the hermetic toolchain is downloaded when in `bzlmod`. However, the same APIs would be available to users using `WORKSPACE`. With this we also allow root modules to restrict which toolchain versions the non-root modules, which may be helpful when optimizing the CI runtimes so that we don't waste time downloading multiple `micro` versions of the same `3.X` python version, which most of the times have identical behavior. Whilst at it, tweak the `semver` implementation to allow for testing of absence of values in the original input. Work towards bazel-contrib#2081 and this should be one of the last items that are blocking bazel-contrib#1361 from the API point of view.
aignas
force-pushed
the
feat/python-override
branch
from
45984a5 to
42df522
Compare
rickeylev
reviewed
Sep 20, 2024
Collaborator
rickeylev
left a comment
rickeylev
left a comment
There was a problem hiding this comment.
Reviewed everything but the python.bzl part and its tests. Just some doc fixes thus far.
rickeylev
approved these changes
Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR the users could not override how the hermetic toolchain
is downloaded when in
bzlmod. However, the same APIs would beavailable to users using
WORKSPACE. With this we also allow rootmodules to restrict which toolchain versions the non-root modules, which
may be helpful when optimizing the CI runtimes so that we don't waste
time downloading multiple
microversions of the same3.Xpythonversion, which most of the times have identical behavior.
Whilst at it, tweak the
semverimplementation to allow for testing ofabsence of values in the original input.
Work towards #2081 and this should be one of the last items that are
blocking #1361 from the API point of view.
Replaces #2151.