change(pypi): use the python package version instead of sha in repo names#2366
Closed
aignas wants to merge 2 commits intobazel-contrib:mainfrom
Closed
change(pypi): use the python package version instead of sha in repo names#2366aignas wants to merge 2 commits intobazel-contrib:mainfrom
aignas wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
…ames Initially the repo name generate was very conservative and we had sha256 as the endings of the repo names. With this change we have more human readable repository names. In order to still comply with the bazel label rules, we are normalizing the versions to only have `_` and `.` characters. This is an alternative fix to the error message seen in bazel-contrib#1837 (comment)
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Nov 1, 2024
Collaborator
Author
|
Having dots in the filenames is preblematic and the current scheme is good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially the repo name generate was very conservative and we had sha256
as the endings of the repo names. With this change we have more human
readable repository names. In order to still comply with the bazel label
rules, we are normalizing the versions to only have
_and.characters.
This is an alternative fix to the error message seen in
#1837 (comment)