fix(pypi): handle multiple versions of the same package when parsing requirements files#2377
Merged
aignas merged 2 commits intobazel-contrib:mainfrom Nov 18, 2024
Conversation
ewianda
commented
Nov 6, 2024
aignas
reviewed
Nov 14, 2024
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
4 times, most recently
from
3e05fbf to
3002d39
Compare
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
from
3002d39 to
273b162
Compare
Contributor
Author
Yes that is correct |
aignas
changed the title
Collaborator
|
I have reworded the commit message a little bit and changed the title since this is more like a fix to an existing feature rather than a new featuer. LGTM in general, could you please add a CHANGELOG.md note as well that this PR fixes an open issue? Something like:
|
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
from
273b162 to
23e7f7f
Compare
aignas
approved these changes
Nov 18, 2024
aignas
requested changes
Nov 18, 2024
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Ah, could you please move the changelog entry to the unreleased block? It might have messed up during a merge/rebase.
ewianda
force-pushed
the
feat-pip-parse-handle-local-versions
branch
from
8653c45 to
06cfc3c
Compare
aignas
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it possible to handle local versions of packages,
which is extremely useful with PyTorch. With this change, it is
possible to have different local versions of the same package in the
requirements.txtfile translated to validwhl_libraryrepositories.Fixes #2337