fix(uv): Fix sha256 for uv binary for aarch64-apple-darwin#2422
Merged
aignas merged 3 commits intobazel-contrib:mainfrom Nov 18, 2024
Merged
fix(uv): Fix sha256 for uv binary for aarch64-apple-darwin#2422aignas merged 3 commits intobazel-contrib:mainfrom
aignas merged 3 commits intobazel-contrib:mainfrom
Conversation
As can be seen here: https://github.com/astral-sh/uv/releases/download/0.4.25/uv-aarch64-apple-darwin.tar.gz.sha256, the current has in rules_python (35786030f926e3d34d186edc0ea3989698e57755852af9ae4b39da5109abcbfa) is incorrect and should be bb2ff4348114ef220ca52e44d5086640c4a1a18f797a5f1ab6f8559fc37b1230 Fixes bazel-contrib#2411
aignas
approved these changes
Nov 18, 2024
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Thanks. Just out of curiosity, how are you using the uv tool today?
Contributor
Author
|
In the repo I discovered this in, it was being used to build a universal lock file to simplify lock file management, as there were aarch64-darwin, x86_64-darwin and x86_64-linux computers being used in this repo, and I wanted something that would work for all. I think this would also have been do able using multiple pip_parse and multiple compile_pip_requirements, but uv worked, and was much faster than previously (where that only resolved for one platform). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uvcannot be used on aarch64-apple-darwin computers because the sha256sum is incorrect.The correct version can be seen here.
Fixes #2411