feat(pypi): Add extra_hub_aliases to pip_repository too#2426
Merged
aignas merged 5 commits intobazel-contrib:mainfrom Nov 19, 2024
Merged
feat(pypi): Add extra_hub_aliases to pip_repository too#2426aignas merged 5 commits intobazel-contrib:mainfrom
aignas merged 5 commits intobazel-contrib:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
497c946 to
391cde8
Compare
391cde8 to
88df4f8
Compare
Collaborator
|
LGTM, thanks for the contribution, things to make this mergeable:
|
2347039 to
65ada63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra_hub_aliases feature from #2369 has bindings in the pip extension
for bzlmod users, but not pip_repository for WORKSPACE users. But it
can work for either, so this patch moves it to the list of attrs the
two share and makes it work with the latter.