fix: make plain zipapp work with bootstrap=script#2598
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Feb 2, 2025
Merged
fix: make plain zipapp work with bootstrap=script#2598rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
rickeylev
force-pushed
the
fix.bootstrap.script.zip.filegroup
branch
from
182ebbe to
9629d7a
Compare
aignas
approved these changes
Feb 1, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Thanks for the test.
The only thing left is a Changelog note about the fixed issue.
Collaborator
Author
|
Changelog updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__main__.pytemplate (zip_main_template.py) was using the wrong path when creatingthe interpreter symlinks. It as computing it correctly, just the wrong variable was used
in the symlink() call.
To fix, pass the correct variable.
Also adds a test to check that it's runnable.
Fixes #2596