feat(rules): add main_module attribute to run a module name (python -m)#2671
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Mar 19, 2025
Merged
feat(rules): add main_module attribute to run a module name (python -m)#2671rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
aignas
approved these changes
Mar 17, 2025
| This is mutually exclusive with {obj}`main_module`. | ||
| """, | ||
| ), | ||
| "main_module": lambda: attrb.String( |
Collaborator
There was a problem hiding this comment.
nit: what about main becoming main_module if it cannot find the file in srcs?
That said, then we would have worse error messages, so this solution is also good.
Collaborator
Author
There was a problem hiding this comment.
I'd rather not because it's not clear how to transform the file name into a module name.
Collaborator
|
Im looking forward to trying: Or even better: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the ability to run a module name instead of a file path, aka
python -mstyle of invocation.This allows a binary/test to specify what the main module is without having to
have a direct dependency on the entry point file.
As a side effect, the
srcsattribute is no longer required.Fixes #2539