fix(rules): make the srcs trully optional#2768
Merged
aignas merged 6 commits intobazel-contrib:mainfrom Apr 13, 2025
Merged
Conversation
With this PR we mark the srcs attribute as optional as we can leverage the `main_module` to just run things from the deps. Fixes bazel-contrib#2765
aignas
commented
Apr 11, 2025
rickeylev
approved these changes
Apr 13, 2025
Collaborator
rickeylev
left a comment
rickeylev
left a comment
There was a problem hiding this comment.
I renamed the tests, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we mark the srcs attribute as optional as we can
leverage the
main_moduleto just run things from the deps.This also removes a long-standing
TODOnote.Fixes #2765