Skip to content

fix: declare PyInfo as provided by test/binary/library#2777

Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom
layus:declare-providers
Apr 20, 2025
Merged

fix: declare PyInfo as provided by test/binary/library#2777
rickeylev merged 3 commits intobazel-contrib:mainfrom
layus:declare-providers

Conversation

@layus
Copy link
Contributor

@layus layus commented Apr 15, 2025

Currently, the rules don't advertise the PyInfo provider through the provides argument
to the rule function. This means that aspects that want to consume PyInfo can't use
required_providers to restrict themselves to the Python rules, and instead have to
apply to all rules.

To fix, add PyInfo to the provides arg of the rules.

Fixes #2506

@layus layus mentioned this pull request Apr 15, 2025
@rickeylev rickeylev changed the title feat: declare more providers in py_* rules fix: declare PyInfo as provided by test/binary/library Apr 15, 2025
@rickeylev
Copy link
Collaborator

This mostly LGTM. The one thing to do is update the changelog.

I renamed this to fix instead of feature. They should have always been declared.

@aignas aignas marked this pull request as ready for review April 15, 2025 23:56
@aignas aignas requested a review from rickeylev as a code owner April 15, 2025 23:56
@rickeylev rickeylev enabled auto-merge April 20, 2025 05:52
@rickeylev rickeylev added this pull request to the merge queue Apr 20, 2025
Merged via the queue into bazel-contrib:main with commit cc46fb2 Apr 20, 2025
2 checks passed
@layus
Copy link
Contributor Author

layus commented Apr 22, 2025

@rickeylev Thank you for pushing this over the line. I planned to do it today, and it seems you did all the remaining work 👏 🙇

@rickeylev
Copy link
Collaborator

You're welcome!

@layus layus deleted the declare-providers branch June 5, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advertise PyInfo provider

3 participants