Skip to content

fix: explicitly symlink all .so files, not just ones with lib prefix #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 3 commits into from
Jan 25, 2026
Merged

fix: explicitly symlink all .so files, not just ones with lib prefix #3538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c06ca26
Fix https://github.com/bazel-contrib/rules_python/issues/3529
gfrankliu Jan 24, 2026
a077445
update CHANGELOG
gfrankliu Jan 24, 2026
9e97021
attempt to fix the test: b_mod_so is not a valid C lib, c_mod.so is.
gfrankliu Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ END_UNRELEASED_TEMPLATE
that are associated with the target's `srcs` are present.
([#3354](https://github.com/bazel-contrib/rules_python/issues/3354)).

{#v1-8-2}
## [1.8.2] - 2026-01-24

{#v1-8-2-fixed}
### Fixed
* (venvs) relax the C library filename check to make tensorflow work
Fixes [#3524](https://github.com/bazel-contrib/rules_python/issues/3529).

{#v1-8-1}
## [1.8.1] - 2026-01-20

Expand Down
11 changes: 2 additions & 9 deletions python/private/venv_runfiles.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,18 +452,11 @@ def get_venv_symlinks(
def _is_linker_loaded_library(filename):
"""Tells if a filename is one that `dlopen()` or the runtime linker handles.

This should return true for regular C libraries, but false for Python
C extension modules.

Python extensions: .so (linux, mac), .pyd (windows)

C libraries: lib*.so (linux), lib*.so.* (linux), lib*.dylib (mac), .dll (windows)
C libraries: *.so (linux), *.so.* (linux), *.dylib (mac), .dll (windows)
"""
if filename.endswith(".dll"):
return True
if filename.startswith("lib") and (
filename.endswith((".so", ".dylib")) or ".so." in filename
):
if filename.endswith((".so", ".dylib")) or ".so." in filename:
return True
return False

Expand Down
22 changes: 18 additions & 4 deletions tests/venv_site_packages_libs/app_files_building/app_files_building_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def _test_optimized_grouping_complex(name):
name = name + "_files",
paths = [
"site-packages/pkg1/a.txt",
"site-packages/pkg1/b/b_mod.so",
"site-packages/pkg1/b/b_mod_so",
"site-packages/pkg1/c/c1.txt",
"site-packages/pkg1/c/c2.txt",
"site-packages/pkg1/d/d1.txt",
Expand All @@ -147,6 +147,10 @@ def _test_optimized_grouping_complex(name):
"site-packages/pkg1/q1/q2a/q3/q3a.txt",
"site-packages/pkg1/q1/q2a/q3/q3b.txt",
"site-packages/pkg1/q1/q2b/q2b.txt",
"site-packages/pkg1/q1/q2c/c_mod.so",
"site-packages/pkg1/q1/q2c/q2.txt",
"site-packages/pkg1/q1/q2c/q3/q3a.txt",
"site-packages/pkg1/q1/q2c/q3/q3b.txt",
],
)
analysis_test(
Expand Down Expand Up @@ -181,7 +185,7 @@ def _test_optimized_grouping_complex_impl(env, target):
"pkg1/b",
link_to_path = rr + "pkg1/b",
files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/b/b_mod.so",
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/b/b_mod_so",
],
),
_venv_symlink("pkg1/c", link_to_path = rr + "pkg1/c", files = [
Expand Down Expand Up @@ -210,6 +214,16 @@ def _test_optimized_grouping_complex_impl(env, target):
_venv_symlink("pkg1/q1/q2b", link_to_path = rr + "pkg1/q1/q2b", files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/q1/q2b/q2b.txt",
]),
_venv_symlink("pkg1/q1/q2c/c_mod.so", link_to_path = rr + "pkg1/q1/q2c/c_mod.so", files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/q1/q2c/c_mod.so",
]),
_venv_symlink("pkg1/q1/q2c/q2.txt", link_to_path = rr + "pkg1/q1/q2c/q2.txt", files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/q1/q2c/q2.txt",
]),
_venv_symlink("pkg1/q1/q2c/q3", link_to_path = rr + "pkg1/q1/q2c/q3", files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/q1/q2c/q3/q3a.txt",
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg1/q1/q2c/q3/q3b.txt",
]),
]
expected = sorted(expected, key = lambda e: (e.link_to_path, e.venv_path))
env.expect.that_collection(
Expand All @@ -226,7 +240,7 @@ def _test_optimized_grouping_single_toplevel(name):
paths = [
"site-packages/pkg2/__init__.py",
"site-packages/pkg2/a.txt",
"site-packages/pkg2/b_mod.so",
"site-packages/pkg2/b_mod_so",
],
)
analysis_test(
Expand Down Expand Up @@ -256,7 +270,7 @@ def _test_optimized_grouping_single_toplevel_impl(env, target):
files = [
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg2/__init__.py",
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg2/a.txt",
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg2/b_mod.so",
"tests/venv_site_packages_libs/app_files_building/site-packages/pkg2/b_mod_so",
],
),
]
Expand Down