Skip to content

fix(pip): simply extract whl contents to the current directory #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aignas merged 3 commits into from
Jan 27, 2026
Merged

fix(pip): simply extract whl contents to the current directory #3549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6756f2a
fix(pip): simply extract whl contents to the current directory
aignas Jan 27, 2026
c9be44d
fixup
aignas Jan 27, 2026
a171cff
another fixp
aignas Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ END_UNRELEASED_TEMPLATE
that are associated with the target's `srcs` are present.
([#3354](https://github.com/bazel-contrib/rules_python/issues/3354)).

{#v1-8-3}
## [1.8.3] - 2026-01-27

{#v1-8-3-fixed}
### Fixed
* (pipstar) Fix whl extraction on Windows when bazelrc has XX flags.
Fixes [#3543](https://github.com/bazel-contrib/rules_python/issues/3543).

{#v1-8-2}
## [1.8.2] - 2026-01-24

Expand Down
5 changes: 2 additions & 3 deletions python/private/pypi/whl_extract.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def whl_extract(rctx, *, whl_path, logger):
whl_path: the whl path to extract.
logger: The logger to use
"""
install_dir_path = whl_path.dirname.get_child("site-packages")
install_dir_path = rctx.path("site-packages")
repo_utils.extract(
rctx,
archive = whl_path,
Expand All @@ -30,7 +30,6 @@ def whl_extract(rctx, *, whl_path, logger):
dist_info_dir.get_child("INSTALLER"),
"https://github.com/bazel-contrib/rules_python#pipstar",
)
repo_root_dir = whl_path.dirname

# Get the <prefix>.dist_info dir name
data_dir = dist_info_dir.dirname.get_child(dist_info_dir.basename[:-len(".dist-info")] + ".data")
Expand All @@ -54,7 +53,7 @@ def whl_extract(rctx, *, whl_path, logger):
# The prefix does not exist in the wheel, we can continue
continue

for (src, dest) in merge_trees(src, repo_root_dir.get_child(dest_prefix)):
for (src, dest) in merge_trees(src, rctx.path(dest_prefix)):
logger.debug(lambda: "Renaming: {} -> {}".format(src, dest))
rctx.rename(src, dest)

Expand Down