Remove reference to deprecated rule in README#404
Closed
martis42 wants to merge 2 commits intobazel-contrib:masterfrom
martis42:patch-1
Closed
Remove reference to deprecated rule in README#404martis42 wants to merge 2 commits intobazel-contrib:masterfrom martis42:patch-1
martis42 wants to merge 2 commits intobazel-contrib:masterfrom
martis42:patch-1
Conversation
thundergolfer
approved these changes
Jan 24, 2021
|
https://github.com/bazelbuild/rules_python/blob/master/docs/pip.md#pip_repositories is still around, though looks like the whole file needs a refresh, so can be done separately to this. |
Contributor
Author
|
work was duplicated here (strangely after positiv review in this PR) #407 |
|
Sorry @martis42, I think I neglected to merge it thinking that contributors had merge-after-approve abilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
When following the guidelines in the README for setting up a workspace using the pip packaging rules one receives the following warning when executing bazel commands:
DEBUG: .../external/rules_python/python/pip.bzl:61:10: DEPRECATED: the pip_repositories rule has been replaced with pip_install, please see rules_python 0.1 release notesCaused here.
Issue Number: N/A
What is the new behavior?
By not including the depecated rule in the WORKSPACE file, no more warning is generated. No functionality is lost.
Does this PR introduce a breaking change?
Other information
N/A