Skip to content

Conversation

@alexeagle
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alexeagle alexeagle merged commit d2d08a7 into bazel-contrib:main Sep 12, 2021
jheaff1 added a commit to jheaff1/rules_python that referenced this pull request Jan 5, 2022
PR bazel-contrib#529 updated `click` to a version which depends on `colorama` on
Windows. This broke `compile_pip_requirements` on windows. This commit
resolves the issue by adding colorama as a dependency.
@jheaff1 jheaff1 mentioned this pull request Jan 5, 2022
12 tasks
alexeagle added a commit that referenced this pull request Jan 30, 2022
PR #529 updated `click` to a version which depends on `colorama` on
Windows. This broke `compile_pip_requirements` on windows. This commit
resolves the issue by adding colorama as a dependency.

Co-authored-by: Alex Eagle <eagle@post.harvard.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants