Fix false positive tests in CI for Windows #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested review from
andyscott,
brandjon,
lberki and
thundergolfer
as code owners
UebelAndre
commented
Jan 7, 2022
Contributor
Author
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
@jheaff1 would you mind taking a look to see if I missed anything? And maybe help me address some TODOs? 😅 🙏
UebelAndre
changed the title
12 tasks
Contributor
|
I’m suprised the diff_tests works in CI, as diff_test is broken when using |
Contributor
Author
|
@jheaff1 Thanks so much for your help! |
Contributor
My pleasure, although you did 99% of the work, so thank you! 😂 |
UebelAndre
changed the title
Contributor
Author
|
As all other changes have been merged, this PR is just left with #597 |
f0rmiga
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the integration test runner does not report errors for windows.
Issue Number: N/A
What is the new behavior?
The test runner has been fixed and the examples/tests updated to be compatible with windows.
Does this PR introduce a breaking change?
Other information
This PR includes the following which are both required to get passing windows builds.