Allow overriding config attrs in pip_parse-generated install_deps #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvolkman
requested review from
brandjon,
lberki and
thundergolfer
as code owners
jvolkman
force-pushed
the
dev/install_deps_overrides
branch
from
135132f to
436529a
Compare
groodt
requested review from
groodt
and removed request for
brandjon,
lberki and
thundergolfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
pip_parsegenerates arequirements.bzlwhich can be vendored by rulesets to install Pypi-sourced Python dependencies. But theinstall_depsfunction doesn't allow any configuration. Most importantly, it doesn't allow specifying thepython_interpreter_targetpresent in the consuming environment.What is the new behavior?
install_depsnow takes an optional**whl_library_kwargswhich can be used to override values that were specified whenrequirements.bzlwas generated.Does this PR introduce a breaking change?