Skip to content

Conversation

@alexeagle
Copy link
Contributor

…ated requirements.txt (#690)"

This reverts commit aef17ad.

Fixes #766

@alexeagle alexeagle force-pushed the revert_690 branch 2 times, most recently from 29a1607 to cf4ef3d Compare August 17, 2022 00:19
@alexeagle alexeagle requested a review from groodt August 17, 2022 01:00
@hrfuller
Copy link
Contributor

hrfuller commented Aug 18, 2022

I know we decided this kind of drive-by change doesn't follow our principles for evolving the project, and makes the code that much harder to read, but just curious were there any known breakages caused by this? Just saw the linked ticket.

Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit edfd9f4 into main Aug 27, 2022
@groodt groodt deleted the revert_690 branch August 27, 2022 22:07
Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local relative requirements compile fails under 0.10.0+

5 participants