Skip to content

Fix ability to download windows toolchains on case sensitive unix systems #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
groodt merged 2 commits into from
Aug 27, 2022
Merged

Fix ability to download windows toolchains on case sensitive unix systems #797

groodt merged 2 commits into from
Aug 27, 2022

Conversation

@UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Aug 19, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

relates to #769

Currently a fail message prevents downloading a windows toolchain on a case sensitive unix host.

What is the new behavior?

Toolchains can now be downloaded.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review August 19, 2022 01:52
groodt
groodt approved these changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit 5ff0dc8 into bazel-contrib:main Aug 27, 2022
@UebelAndre UebelAndre deleted the case branch August 27, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@groodt groodt groodt approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@UebelAndre @groodt