Add a 'tools' attribute to the rules, similar to genrule#41
Open
novas0x2a wants to merge 1 commit intobazel-contrib:mainfrom
Open
Add a 'tools' attribute to the rules, similar to genrule#41novas0x2a wants to merge 1 commit intobazel-contrib:mainfrom
novas0x2a wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
It's common for shell scripts to use external binaries (things from coreutils being a common example). This provides a way to declare those dependencies explicitly, and ensure they are in the correct configuration to be run as part of the script.
Author
|
Hm. I didn't realize that this module prioritizes using the java versions of the rules; that means this change will break the tests (and just the tests) on bazel 6 and 7. Is there a way to set the tools-attribute tests up such that they only run on the starlark version? Should I just drop the tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's common for shell scripts to use external binaries (things from coreutils being a common example). This provides a way to declare those dependencies explicitly, and ensure they are in the correct configuration to be run as part of the script.