Override OS version possible?

[fzakaria]

Hello!

I see it's possible to set llvm_versions per OS & Arch but I'm interested in forcing my OS version.
I work at Google and I'm on a fork of Debian that doesn't have any version identifier that can be used for detection.

Instead I'd like to force set the version based on which glibc I have available.
(Is that the only requirement for OS versions that needs to be checked?)

For reference:

❯ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux rodete"
NAME="Debian GNU/Linux rodete"
VERSION_CODENAME=rodete
ID=debian
HOME_URL="https://go/glinux"
SUPPORT_URL="https://go/techstop"
BUG_REPORT_URL="https://go/techstop"

I'm on /usr/lib/x86_64-linux-gnu/libc.so.6 FWIW.

The code at the moment defaults to 20.04 for my OS release because it has no VERSION_ID
https://github.com/bazel-contrib/toolchains_llvm/blob/master/toolchain/internal/release_name.bzl#L121

[jsharpe]

The version is about mapping to one of the binary releases provided by upstream using the mappings in this file: https://github.com/bazel-contrib/toolchains_llvm/blob/master/toolchain/internal/llvm_distributions.bzl
glibc is likely one of the requirements but I think many of those builds aren't completely hermetic and rely on system packages such as libtinfo and so its a case of working out which ones work on your OS and getting the mapping logic to work. I'd support having a manual override parameter to be able to force a os version in the repository rules that configure this.

[fzakaria]

@jsharpe how do people configure their bazel toolchain with llvm this way if they support various OS versions?
You can't guarantee the version?

In any case, I'd be happy to upstream support for manual override for our particular use-case.
Maybe a new key for when the version can't be found or should it override always?

If you can point me to a few places to get started I can give it a crack.
(sorry for the late response here)

(As someone who works on NixOS... toolchains in Bazel are such a mess)

[siddharthab]

Can you try point 2 in https://github.com/bazel-contrib/toolchains_llvm?tab=readme-ov-file#bring-your-own-llvm?

Example of providing the urls attribute is here.

toolchains_llvm/tests/MODULE.bazel

Lines 77 to 100 in ca816f6

	llvm.toolchain(
	name = "llvm_toolchain_with_urls",
	llvm_versions = {
	"": "15.0.6",
	"darwin-aarch64": "15.0.7",
	"darwin-x86_64": "15.0.7",
	},
	sha256 = {
	"": "38bc7f5563642e73e69ac5626724e206d6d539fbef653541b34cae0ba9c3f036",
	"darwin-aarch64": "867c6afd41158c132ef05a8f1ddaecf476a26b91c85def8e124414f9a9ba188d",
	"darwin-x86_64": "d16b6d536364c5bec6583d12dd7e6cf841b9f508c4430d9ee886726bd9983f1c",
	},
	strip_prefix = {
	"": "clang+llvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04",
	"darwin-aarch64": "clang+llvm-15.0.7-arm64-apple-darwin22.0",
	"darwin-x86_64": "clang+llvm-15.0.7-x86_64-apple-darwin21.0",
	},
	urls = {
	"": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.6/clang+llvm-15.0.6-x86_64-linux-gnu-ubuntu-18.04.tar.xz"],
	"darwin-aarch64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.7/clang+llvm-15.0.7-arm64-apple-darwin22.0.tar.xz"],
	"darwin-x86_64": ["https://github.com/llvm/llvm-project/releases/download/llvmorg-15.0.7/clang+llvm-15.0.7-x86_64-apple-darwin21.0.tar.xz"],
	},
	)
	use_repo(llvm, "llvm_toolchain_with_urls")

I can add a clause for VERSION_CODENAME here if VERSION_ID is missing.

As of now, your key for the urls and other attributes would be debian-x86_64, and with VERSION_CODENAME, your host_os_key would be debian-rodete-x86_64. See host_os_arch_dict_value for more details on how the key lookups are done.

[siddharthab]

Please reopen if something is unclear, but I think your use case should already be covered. Worst case, you can add your own specific logic to release_name.bzl.

[fzakaria]

@siddharthab I think the problem though is my OS version is not detected as part of the host_arch_dict_value.
I think the issue should remain open to support VERSION_CODENAME .

Ah, I see you added the commit mentioning it -- I will try ; thank you.