feat: add support for arbitrary headers rctx.download[_and_extract] by thesayyn · Pull Request #19501 · bazelbuild/bazel

thesayyn · 2023-09-12T20:48:57Z

thesayyn · 2023-10-25T20:42:10Z

@fmeum this is not quite what i want. Even with change, if you are using credential helpers, or some other credential factory, the headers disappear which doesn't solve the problem we are having. I want these headers to be set unconditionally for all URLs. credential helpers might override them but should not make the disappear.

Would that still be acceptable here or should i go through an RFC process first?

fmeum · 2023-10-29T14:19:03Z

I don't know much about credential helpers. @Yannic Could you provide advice here? How should a credential helper interact with headers specified in Starlark?

tjgq · 2023-10-29T15:25:55Z

I don't know much about credential helpers. @Yannic Could you provide advice here? How should a credential helper interact with headers specified in Starlark?

We should merge headers from the two sources. If the same header is provided from both sides, the value from the credential helper should take precedence, matching the preexisting behavior for the Starlark auth attribute (see https://cs.opensource.google/bazel/bazel/+/master:src/test/shell/bazel/starlark_repository_test.sh;l=1817;drc=175a18dc9f58ba40e287336e06a26617a0becd0a).

Yannic

LGTM

thesayyn · 2023-10-31T16:38:27Z

@fmeum this is ready I believe. After I get the okay from you, I'll add the tests.

fmeum

This looks good to me with a few comments. Since @meteorcloudy and @tjgq seem to be on board, I think that you can go ahead with the tests.

thesayyn · 2023-11-08T17:26:31Z

This looks good to me with a few comments. Since @meteorcloudy and @tjgq seem to be on board, I think that you can go ahead with the tests.

Great, will get into that today.

…ownloader/HttpConnectorMultiplexer.java Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

thesayyn · 2023-11-24T06:05:25Z

@fmeum this should be ready. I'll wait for the CI.

It would be sweet if we could get this cherry picked into 7.0

fmeum · 2023-11-24T07:57:35Z

@thesayyn There are still CI failures.

As far as I know the final RC for 7.0.0 is to be cut on Monday.

@meteorcloudy Could you already take a look?

meteorcloudy

Thanks, please fix the presubmit!

thesayyn · 2023-11-24T16:02:10Z

There are still CI failures.

it should pass now, will carefully watch and fix it if it doesn't throughout the day.

meteorcloudy · 2023-12-06T10:03:05Z

@bazel-io fork 7.1.0

meteorcloudy · 2023-12-06T10:51:07Z

@thesayyn Can you please resolve the merge conflicts?

tjgq

Looks good; do you mind rebasing to fix the merge conflict, and addressing my last two comments?

tjgq

Thanks for going the extra mile and implementing the more complex dict value type :)

thesayyn · 2023-12-07T02:18:27Z

Probably 7.1

Is there possibility that this could be released with 7.0? Since parallel downloads feature made it there it would be great to have this too.

meteorcloudy · 2023-12-07T10:55:03Z

@thesayyn Sorry, Bazel 7 release has been lasting for more than a month, we already pushed back many feature cherry-picks to 7.1.0. We'll start preparing 7.1.0 shortly after Bazel 7 is out.

tjgq · 2023-12-07T13:05:43Z

@bazel-io fork 7.1.0

fixes #17829 Closes #19501. PiperOrigin-RevId: 588750878 Change-Id: I11c982864135d8e1c4420099ce27f67accd3fe20

…ct] (#20979) fixes #17829 Closes #19501. PiperOrigin-RevId: 588750878 Change-Id: I11c982864135d8e1c4420099ce27f67accd3fe20 Co-authored-by: thesayyn <thesayyn@gmail.com>

github-actions Bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Sep 12, 2023

thesayyn mentioned this pull request Sep 12, 2023

Allow arbitrary headers to sent with Bazel Downloader #17829

Closed

fmeum reviewed Sep 13, 2023

View reviewed changes

thesayyn force-pushed the arb_headers branch from f4844bb to 94eb964 Compare October 25, 2023 21:35

thesayyn requested a review from a team as a code owner October 25, 2023 21:35

thesayyn requested a review from fmeum October 25, 2023 21:36

thesayyn added 2 commits October 25, 2023 14:41

feat: add support for arbitrary headers rctx.download[_and_extract]

09ff174

refactor

e89950d

thesayyn force-pushed the arb_headers branch from 94eb964 to e89950d Compare October 25, 2023 21:45

Yannic reviewed Oct 29, 2023

View reviewed changes

thesayyn added 4 commits October 30, 2023 10:15

adress nits

e40f4ea

remove .toList

fa54b76

fix tests

9637472

fix tests

f12b138

fmeum reviewed Nov 3, 2023

View reviewed changes

thesayyn and others added 4 commits November 23, 2023 13:20

Update src/main/java/com/google/devtools/build/lib/bazel/repository/d…

2eecc54

…ownloader/HttpConnectorMultiplexer.java Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

Update src/main/java/com/google/devtools/build/lib/bazel/repository/d…

8a52342

…ownloader/HttpConnectorMultiplexer.java Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>

add tests

d07484b

Merge remote-tracking branch 'origin/master' into arb_headers

54547e5

meteorcloudy reviewed Nov 24, 2023

View reviewed changes

Comment thread ...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java Outdated

revert

8b6cbba

bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023

bazel-io mentioned this pull request Dec 6, 2023

[7.1.0] feat: add support for arbitrary headers rctx.download[_and_extract] #20448

Closed

bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 6, 2023

tjgq approved these changes Dec 6, 2023

View reviewed changes

tjgq reviewed Dec 6, 2023

View reviewed changes

Comment thread ...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java Outdated

Comment thread ...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java Outdated

nits

e7f99a9

thesayyn force-pushed the arb_headers branch 2 times, most recently from 4b2879b to e2578f4 Compare December 6, 2023 23:15

Merge remote-tracking branch 'origin/master' into arb_headers

2467c6a

thesayyn force-pushed the arb_headers branch from e2578f4 to 2467c6a Compare December 6, 2023 23:24

tjgq approved these changes Dec 6, 2023

View reviewed changes

tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 6, 2023

copybara-service Bot closed this in 2b8885e Dec 7, 2023

github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 7, 2023

bazel-io mentioned this pull request Dec 7, 2023

[7.1.0] feat: add support for arbitrary headers rctx.download[_and_extract] #20466

Closed

thesayyn mentioned this pull request Dec 11, 2023

.bazelrc generated range.sh credential helper invalidates other types of authorization at the host level chainguard-dev/rules_apko#42

Closed

thesayyn mentioned this pull request Jan 11, 2024

Release 2.0 bazel-contrib/rules_oci#456

Closed

Wyverald pushed a commit that referenced this pull request Jan 22, 2024

Add support for arbitrary headers to rctx.download[_and_extract]

f4e3302

fixes #17829 Closes #19501. PiperOrigin-RevId: 588750878 Change-Id: I11c982864135d8e1c4420099ce27f67accd3fe20

Wyverald mentioned this pull request Jan 22, 2024

[7.1.0] Add support for arbitrary headers to rctx.download[_and_extract] #20979

Merged

thesayyn mentioned this pull request May 8, 2024

Drop curl fallback for oci_pull bazel-contrib/rules_oci#562

Closed

axeluhlig mentioned this pull request Aug 22, 2024

oci_pull() fails with "The registry sent a manifest with schemaVersion=1" when using v2.0.0-beta2 bazel-contrib/rules_oci#678

Closed

Conversation

thesayyn commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thesayyn commented Oct 25, 2023

Uh oh!

fmeum commented Oct 29, 2023

Uh oh!

tjgq commented Oct 29, 2023

Uh oh!

Yannic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thesayyn commented Oct 31, 2023

Uh oh!

fmeum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thesayyn commented Nov 8, 2023

Uh oh!

thesayyn commented Nov 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fmeum commented Nov 24, 2023

Uh oh!

meteorcloudy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thesayyn commented Nov 24, 2023

Uh oh!

meteorcloudy commented Dec 6, 2023

Uh oh!

meteorcloudy commented Dec 6, 2023

Uh oh!

tjgq left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tjgq left a comment

Choose a reason for hiding this comment

Uh oh!

thesayyn commented Dec 7, 2023

Uh oh!

meteorcloudy commented Dec 7, 2023

Uh oh!

tjgq commented Dec 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

thesayyn commented Sep 12, 2023 •

edited

Loading

thesayyn commented Nov 24, 2023 •

edited

Loading