Mark gcc-<version> as gcc instead of compiler in Unix CC toolchain#20350
Closed
robinlinden wants to merge 2 commits intobazelbuild:masterfrom
Closed
Mark gcc-<version> as gcc instead of compiler in Unix CC toolchain#20350robinlinden wants to merge 2 commits intobazelbuild:masterfrom
gcc instead of compiler in Unix CC toolchain#20350robinlinden wants to merge 2 commits intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
team-Rules-CPP
fmeum
reviewed
Nov 29, 2023
Collaborator
fmeum
left a comment
fmeum
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Just a few drive-by comments, this will have to be reviewed by a team member.
You can run bazel run //src/test/tools/bzlmod:update_default_lock_file and commit the result to address the CI failures.
robinlinden
force-pushed
the
detect-more-gcc-variations
branch
2 times, most recently
from
fe56c07 to
de64050
Compare
Author
Thank you for the initial gcc-marking, as well as having a look and explaining the lock-file updating! I had a look at a few random passing PRs and didn't see any lock-file updates, so I figured I just had the worst of luck. The drive-by comments are very helpful. :) |
comius
requested changes
Dec 28, 2023
comius
added
awaiting-user-response
Previously only gcc-binaries named exactly `gcc` were marked as `gcc`, with the others being marked as `compiler`. Fixes bazelbuild#17794
robinlinden
force-pushed
the
detect-more-gcc-variations
branch
from
de64050 to
650d26b
Compare
Author
|
@comius I can't update labels here, but this is awaiting-review again. |
comius
approved these changes
Feb 5, 2024
comius
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
Collaborator
|
@bazel-io fork 7.1.0 |
iancha1992
added a commit
to iancha1992/bazel
that referenced
this pull request
Feb 6, 2024
Fixes bazelbuild#17794 I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g. `gcc-11`, or search the `$PATH` for a `gcc-<version>`? Closes bazelbuild#20350. PiperOrigin-RevId: 604543138 Change-Id: I71ebbac77e4e32ebc5d99ec4a81415727af12cbc
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
…toolchain (#21224) Fixes #17794 I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g. `gcc-11`, or search the `$PATH` for a `gcc-<version>`? Closes #20350. Commit 8877183 PiperOrigin-RevId: 604543138 Change-Id: I71ebbac77e4e32ebc5d99ec4a81415727af12cbc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17794
I was looking at writing a test for this, but not sure how you'd like me to go about that. Hard-code a gcc, e.g.
gcc-11, or search the$PATHfor agcc-<version>?