[7.0.0] Generalize memory and cpu tracking#20396
Merged
iancha1992 merged 1 commit intobazelbuild:release-7.0.0from Nov 30, 2023
Merged
[7.0.0] Generalize memory and cpu tracking#20396iancha1992 merged 1 commit intobazelbuild:release-7.0.0from
iancha1992 merged 1 commit intobazelbuild:release-7.0.0from
Conversation
Remove special handling of cpu and memory, and instead track them as any other resource. This has a few advantages: - Significant code clean up, keep only the logic for generic resource around - Consistent resources type (double) for all resource Relates to bazelbuild#19679 Closes bazelbuild#19839. PiperOrigin-RevId: 585926931 Change-Id: Id0d6a14e9c151c3895f55d1808b6bd66eecf98b3
iancha1992
added
team-Performance
github-actions
Bot
added
team-Rules-CPP
Wyverald
approved these changes
Nov 30, 2023
keertk
removed
team-Configurability
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove special handling of cpu and memory, and instead track them as any other resource. This has a few advantages:
Relates to #19679
Closes #19839.
Commit ebe4d0d
PiperOrigin-RevId: 585926931
Change-Id: Id0d6a14e9c151c3895f55d1808b6bd66eecf98b3