Add bash completion for external targets #20693
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Add bash completion for external targets #20693fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Collaborator
Author
fmeum
force-pushed
the
20631-bash-completion
branch
4 times, most recently
from
d23d7df to
2ee04c7
Compare
github-actions
Bot
added
team-ExternalDeps
fmeum
force-pushed
the
20631-bash-completion
branch
from
2ee04c7 to
eaa8e4d
Compare
Member
|
|
fmeum
force-pushed
the
20631-bash-completion
branch
from
eaa8e4d to
c940d31
Compare
Collaborator
Author
|
@Wyverald This PR is no longer stacked. |
Collaborator
Author
|
@meteorcloudy The Darwin build fails even though I think I haven't touched any files that could affect the Python extension hash. Is this broken on master? |
Member
|
Yes, this is now fixed at HEAD, please rebase! |
Completion for both repository names and targets in (fetched) external repositories is provided based on `bazel mod dump_repo_mapping`.
fmeum
force-pushed
the
20631-bash-completion
branch
from
c940d31 to
b29e867
Compare
Collaborator
Author
|
Tests are passing, thanks! |
Wyverald
approved these changes
Jan 30, 2024
Member
Wyverald
left a comment
Wyverald
left a comment
There was a problem hiding this comment.
the tests look great, so I'll just trust you with the bash parts :D thank you so much!
Wyverald
added
awaiting-PR-merge
meteorcloudy
approved these changes
Jan 30, 2024
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Same here! Sorry for the late review!
Collaborator
Author
|
@bazel-io fork 7.1.0 |
github-actions
Bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 31, 2024
Completion for both repository names and targets in (fetched) external repositories is provided based on `bazel mod dump_repo_mapping`. RELNOTES: Bazel's Bash completion can now complete external repository labels when using `--enable_bzlmod`. Closes bazelbuild#20693. PiperOrigin-RevId: 602923007 Change-Id: I7c7dfe3d90a2921f473c2d2fedbc054da67932ac
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
Completion for both repository names and targets in (fetched) external repositories is provided based on `bazel mod dump_repo_mapping`. RELNOTES: Bazel's Bash completion can now complete external repository labels when using `--enable_bzlmod`. Closes #20693. Commit a4c3d89 PiperOrigin-RevId: 602923007 Change-Id: I7c7dfe3d90a2921f473c2d2fedbc054da67932ac Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Member
|
The changes in this PR have been included in Bazel 7.1.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion for both repository names and targets in (fetched) external repositories is provided based on
bazel mod dump_repo_mapping.RELNOTES: Bazel's Bash completion can now complete external repository labels when using
--enable_bzlmod.