Skip to content

Fix linker feature detection being performed on wrong linker#20833

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:push-state
Closed

Fix linker feature detection being performed on wrong linker#20833
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:push-state

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Jan 10, 2024

Bazel forces use of lld and ld.gold if found, but performed feature detection on the default linker instead.

Fixes #20834

@github-actions github-actions Bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2024
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Jan 10, 2024

cc @buildbreaker2021 @meteorcloudy

@meteorcloudy meteorcloudy requested a review from comius January 10, 2024 11:15
Bazel forces use of `lld` and `ld.gold` if found, but performed feature
detection on the default linker instead.
@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 12, 2024
@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 15, 2024
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 15, 2024
Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead.

Fixes bazelbuild#20834

Closes bazelbuild#20833.

PiperOrigin-RevId: 598565598
Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6
meteorcloudy pushed a commit that referenced this pull request Jan 15, 2024
Bazel forces use of `lld` and `ld.gold` if found, but performed feature
detection on the default linker instead.

Fixes #20834

Closes #20833.

PiperOrigin-RevId: 598565598
Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6

Closes #20835
@fmeum fmeum deleted the push-state branch January 15, 2024 20:54
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jan 22, 2024
Bazel forces use of `lld` and `ld.gold` if found, but performed feature detection on the default linker instead.

Fixes bazelbuild#20834

Closes bazelbuild#20833.

PiperOrigin-RevId: 598565598
Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6
github-merge-queue Bot pushed a commit that referenced this pull request Jan 29, 2024
…20990)

Bazel forces use of `lld` and `ld.gold` if found, but performed feature
detection on the default linker instead.

Fixes #20834

Closes #20833.

Commit
2bfe045

PiperOrigin-RevId: 598565598
Change-Id: I4890f278c5cc33d4e6a6ebb10d796fb1c22f9ba6

---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading to bazel 7.0.0 gcc fails with: --push-state: unknown option

2 participants