[7.1.0] Allow @repo_name labels in override attributes#21314
Closed
iancha1992 wants to merge 1 commit intobazelbuild:release-7.1.0from
Closed
[7.1.0] Allow @repo_name labels in override attributes#21314iancha1992 wants to merge 1 commit intobazelbuild:release-7.1.0from
@repo_name labels in override attributes#21314iancha1992 wants to merge 1 commit intobazelbuild:release-7.1.0from
Conversation
This is made possible by a refactoring that moves the label parsing of `RepoSpec` attributes coming from module overrides as well as `.bzl` file labels containing repo rules from `BzlmodRepoRuleFunction` into `ModuleFileGlobals`. Also adds a TODO to `BzlmodRepoRuleFunction` to further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels in `RepoSpec`s. Work towards bazelbuild#19301 Closes bazelbuild#21188. PiperOrigin-RevId: 605517195 Change-Id: Id34c81fa9474fef2354ff1fbc898e518a9044640
iancha1992
added
team-ExternalDeps
auto-merge was automatically disabled
February 12, 2024 22:29
Pull request was closed
github-actions
Bot
removed
the
awaiting-review
Member
Author
|
Dupe of #21313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is made possible by a refactoring that moves the label parsing of
RepoSpecattributes coming from module overrides as well as.bzlfile labels containing repo rules fromBzlmodRepoRuleFunctionintoModuleFileGlobals. Also adds a TODO toBzlmodRepoRuleFunctionto further simplify the logic after the next lockfile version bumps, as old lockfiles are now the only source of non-canonical labels inRepoSpecs.Work towards #19301
Closes #21188.
Commit f0ab82d
PiperOrigin-RevId: 605517195
Change-Id: Id34c81fa9474fef2354ff1fbc898e518a9044640