Use strip_files matching CppHelper on strip action#21357
Closed
werkt wants to merge 1 commit intobazelbuild:masterfrom
Closed
Use strip_files matching CppHelper on strip action#21357werkt wants to merge 1 commit intobazelbuild:masterfrom
werkt wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
Bot
added
the
awaiting-review
With native cc rules, bazel only specified strip_files as input to the
automatically generated {name}.stripped action for a cc_binary target.
This change makes the starlark cc rules consistent with native behavior.
werkt
force-pushed
the
cc-strip-files
branch
from
97b82b7 to
146ab29
Compare
comius
added
awaiting-PR-merge
github-actions
Bot
removed
the
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With native cc rules, bazel only specified strip_files as input to the automatically generated {name}.stripped action for a cc_binary target. This change makes the starlark cc rules consistent with native behavior.