Skip to content

[7.1.0] Fix presubmit errors#21529

Closed
iancha1992 wants to merge 2 commits intobazelbuild:release-7.1.0from
iancha1992:cp21528
Closed

[7.1.0] Fix presubmit errors#21529
iancha1992 wants to merge 2 commits intobazelbuild:release-7.1.0from
iancha1992:cp21528

Conversation

@iancha1992
Copy link
Copy Markdown
Member

@iancha1992 iancha1992 commented Feb 29, 2024

Cherry-pick a3f778c and 702118b to fix presubmit issues

lberki and others added 2 commits February 29, 2024 10:10
…put base.

This is legacy functionality from 2009 (in the case of "query") and 2012 (in the case of "print_action", which is when that command was invented).

Motivated by bazelbuild#21005 .

RELNOTES[INC]: "bazel query" and "bazel print_action" can't run under the output base anymore.

PiperOrigin-RevId: 607036900
Change-Id: Ic9272d42d07b802924b4420408146de830a82ad8
Bazel cannot reach to bcr.bazel.build from a ipv4 only machine with --host_jvm_args=-Djava.net.preferIPv6Addresses=true set. Our GCP VMs are ipv4 only and we recently enabled ipv6 for bcr.bazel.build.

Related bazelbuild#21525

PiperOrigin-RevId: 611465054
Change-Id: I0c3d144d12ab167a18075e6719ff8597161798d1
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 29, 2024
@iancha1992 iancha1992 requested a review from a team as a code owner February 29, 2024 18:12
@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label Feb 29, 2024
@iancha1992 iancha1992 enabled auto-merge February 29, 2024 18:13
@iancha1992 iancha1992 requested review from Wyverald, keertk and meteorcloudy and removed request for keertk February 29, 2024 18:18
@meteorcloudy
Copy link
Copy Markdown
Member

We cannot cherry-pick a3f778c since it's an incompatible change. I'll send a PR instead.

auto-merge was automatically disabled March 4, 2024 09:13

Pull request was closed

@github-actions github-actions Bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 4, 2024
@meteorcloudy
Copy link
Copy Markdown
Member

Here you go: #21546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants