Skip to content

Fix git branch detection in release scripts#22405

Closed
fweikert wants to merge 2 commits intobazelbuild:masterfrom
fweikert:master
Closed

Fix git branch detection in release scripts#22405
fweikert wants to merge 2 commits intobazelbuild:masterfrom
fweikert:master

Conversation

@fweikert
Copy link
Copy Markdown
Member

Previously the code failed when the repository was in detached HEAD state (e.g. on CI).

Previously the code failed when the repository was in detached HEAD state (e.g. on CI).
@fweikert fweikert requested review from Wyverald and meisterT May 16, 2024 14:28
@github-actions github-actions Bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 16, 2024
Comment thread scripts/release/common.sh
@fweikert fweikert added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally P1 I'll work on this now. (Assignee required) and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 16, 2024
@fweikert
Copy link
Copy Markdown
Member Author

cc @keertk - this should fix the release docs (once cherrypicked)

@keertk
Copy link
Copy Markdown
Member

keertk commented May 16, 2024

@bazel-io fork 7.2.0

@github-actions github-actions Bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 16, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request May 16, 2024
Previously the code failed when the repository was in detached HEAD state (e.g. on CI).

Closes bazelbuild#22405.

PiperOrigin-RevId: 634564660
Change-Id: I60d87f1f24a1dceec6b74709a571c9630cf6bcc5
@keertk keertk added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 16, 2024
github-merge-queue Bot pushed a commit that referenced this pull request May 17, 2024
Previously the code failed when the repository was in detached HEAD
state (e.g. on CI).

Closes #22405.

PiperOrigin-RevId: 634564660
Change-Id: I60d87f1f24a1dceec6b74709a571c9630cf6bcc5

Commit
2028c47

Co-authored-by: Florian Weikert <fwe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants