add compiler_input_flags_feature and compiler_output_flags_feature#22743
Closed
PikachuHyA wants to merge 1 commit intobazelbuild:masterfrom
Closed
add compiler_input_flags_feature and compiler_output_flags_feature#22743PikachuHyA wants to merge 1 commit intobazelbuild:masterfrom
PikachuHyA wants to merge 1 commit intobazelbuild:masterfrom
Conversation
comius
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
compiler_input_flags_featureandcompiler_output_flags_featureto the features.follow #22717
By default, the features
compiler_input_flags_featureandcompiler_output_flags_featureare included throughCppActionConfigs.javain thegetFeaturesToAppearLastInFeaturesListmethod.For reference, see the relevant code here:
bazel/src/main/java/com/google/devtools/build/lib/rules/cpp/CppActionConfigs.java
Lines 1513 to 1573 in 0dbfacc
Background
I modified
tools/cpp/unix_cc_toolchain_config.bzland found no input and output on macOS when testing #19940 with the new action namesc++20-deps-scanningandc++20-module-compile.As discussed in #22429 (comment), I added these two features to
unix_cc_toolchain_config.bzl.the Windows toolchains already have these features, so no modifications were necessary for
windows_cc_toolchain_config.bzl.bazel/tools/cpp/windows_cc_toolchain_config.bzl
Lines 1073 to 1095 in 786a893
bazel/tools/cpp/windows_cc_toolchain_config.bzl
Lines 960 to 1020 in 786a893
cc @comius