Add python zip file to a output group #9453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change, users can get the python zip file of a certain target without using --build_python_zip_file by bazel build //foo:bar --output_groups=python_zip_file or filegroup( name = "bar_zip", srcs = ["//foo:bar"], output_group = "python_zip_file", )
Contributor
|
This feels like a very promising alternative to subpar executables inside Docker containers. 👍 |
Member
Author
|
/cc @brandjon |
Member
Author
|
Ping @brandjon ! |
brandjon
approved these changes
Oct 17, 2019
Member
brandjon
left a comment
brandjon
left a comment
There was a problem hiding this comment.
This all looks good. Thanks for breaking it into three commits for easier reviewing. Recording my comment wording nits below but I'll apply them in the merge.
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java
Show resolved
Hide resolved
Member
Author
|
Thanks for the review and importing! |
brandjon
approved these changes
Oct 18, 2019
Member
brandjon
left a comment
brandjon
left a comment
There was a problem hiding this comment.
Other changes in internal merge:
- make
createStubFilestatic - add log line to test
- move test from
.../shell/integration/to.../shell/bazel/
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java
Show resolved
Hide resolved
bmclarnon
added a commit
to google-parfait/confidential-federated-compute
that referenced
this pull request
Mar 25, 2024
All new images should be built with bazel, so we don't anticipate needing the loop any more. Also add a filegroup so that we don't need a separate bazel invocation with `--build_python_zip`; see bazelbuild/bazel#9453. Change-Id: I7e2203ac4efbfada7fa69565f6b0f27bf6979f25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, users can get the python zip file of a certain
target without using
--build_python_zipbybazel build //foo:bar --output_groups=python_zip_fileor
Fixes #3530