Install completions into BASH_COMPLETION_USER_DIR#725
Install completions into BASH_COMPLETION_USER_DIR#725NEOatNHNG wants to merge 2 commits intobazelbuild:masterfrom
Conversation
The recommended place to install completions to is the BASH_COMPLETION_USER_DIR which loads completions on demand.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Pull Request Overview
Updates the bash completion installation instructions to use the standard BASH_COMPLETION_USER_DIR location instead of a generic filename. This follows bash completion best practices by installing completions into the user-specific completion directory where they are loaded automatically on demand.
- Modified completion script installation to use BASH_COMPLETION_USER_DIR with XDG fallback
- Added directory creation command to ensure the completion directory exists
- Changed output filename from generic "bash-complete.bash" to specific "bazel.bash"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The recommended place to install completions to is the BASH_COMPLETION_USER_DIR which loads completions on demand.