Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Update external repos to fix the build#30

Merged
laurentlb merged 6 commits intobazelbuild:masterfrom
laszlocsomor:update-grpc
Jan 23, 2020
Merged

Update external repos to fix the build#30
laurentlb merged 6 commits intobazelbuild:masterfrom
laszlocsomor:update-grpc

Conversation

@laszlocsomor
Copy link
Contributor

@laszlocsomor laszlocsomor commented Jan 21, 2020

Updade io_grpc_grpc_java, protobuf_deps, and rules_go to newer versions.
This shall fix the build of //... with Bazel 2.0.0 on Linux.

Fixes #29

@laszlocsomor
Copy link
Contributor Author

There's more work with this. :( Will ping the thread when ready.

@laszlocsomor laszlocsomor changed the title Update io_grpc_grpc_java reference Update external repos to fix the build Jan 22, 2020
@laszlocsomor
Copy link
Contributor Author

Ping! Ready for review. :)
Thanks for your patience!

@laszlocsomor
Copy link
Contributor Author

@dkelmer no longer works on Bazel and @ruperts is away, adding @laurentlb

@laurentlb
Copy link
Contributor

Thanks for the fixes. Could you use http_archive, instead of git_repository?

@laszlocsomor
Copy link
Contributor Author

You're welcome!
Done.

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laurentlb laurentlb merged commit 00431a9 into bazelbuild:master Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

io_grpc_grpc_java declares maven repos with broken URLs

2 participants