`ios_unit_test` doesn't include bundles provided to `data` when using a test host

[jflan-dd]

Resource bundles provided as data arguments to ios_unit_tests aren't bundled into the final .xctest bundle when using test_host.
It is included if test_host is None or if the bundle is provided to the resources argument instead.

apple_precompiled_resource_bundle(
    name = "SnapshotsData",
    bundle_id = "com.jflan.SnapshotsData",
    bundle_name = "Snapshots",
    infoplists = ["Info.plist],
    structured_resources = snapshot_images,
    tags = ["manual"],
)

ios_unit_test(
    name = "UnitTests",
    data = [":SnapshotsData"], # has to be `resources` to work with `test_host`
    minimum_os_version = minimum_os_version,
    runner = test_runner,
    test_host = "//MyApp",
    visibility = ["//visibility:public"],
    deps = [":UnitTests.library"],
)

[brentleyjones]

data and resources are different things for test targets (which are actually a runner and bundle target combined in a macro), which is why there are two attributes. Not saying that this behavior is good, there is probably a bug somewhere, but ideally in my mind data on the test would be available for the test runner instead of the test (and we also have data on the runner for this, but having it on the test allows for per-test test runner data).

[jflan-dd]

@brentleyjones The docs for ios_unit_test don't mention resources, I dug around in the rules a bit to find it when data wasn't working for hosted unit tests.

The docs for data only mention the files being made available to the test.

Files to be made available to the test during its execution.