Cherry-pick batch 1: linking refactoring + dSYM foundation#2905
Closed
luispadron wants to merge 12 commits intomainfrom
Closed
Cherry-pick batch 1: linking refactoring + dSYM foundation#2905luispadron wants to merge 12 commits intomainfrom
luispadron wants to merge 12 commits intomainfrom
Conversation
… to work with the new platform-based resolution that has been added to the shared Apple linker logic. Cherry-pick: 0654124
…s to a method are greater than one. Consolidate and reuse variables where they make sense. Cherry-pick: 2507186
…les themselves. Cherry-pick: f1ed76b
…rtial along with dead code that was present from use of the vestigial AppleDynamicFrameworkInfo fields. Cherry-pick: 28d227a
…puts and the anticipated base name via use of "fragment_support" and "outputs", shared through compilation_support and linking_support. This will be used to reference the unstripped binary that is found in the generated dSYM bundles. Cherry-pick: c19c91b
luispadron
requested review from
aaronsky,
adincebic,
brentleyjones,
keith and
mattrobmattrob
as code owners
luispadron
changed the title
luispadron
force-pushed
the
luis/batch-1-linking-dsym-foundation
branch
from
114ee4e to
f80deb8
Compare
luispadron
force-pushed
the
luis/batch-1-linking-dsym-foundation
branch
from
63f463c to
eb171a5
Compare
…mbols partial. Tests for other platforms and targets besides ios_application will arrive in a following commit. NOTE: includes manual addition of `dsym_variant_flag` since its not public in the upstream code Cherry-pick: 7a0ef14
…e outputs. Add tests for macos_application and macos_command_line_application. Use build_setting_labels flags to reference dsym_variant_flag in test rules when possible. Cherry-pick: b27541a
…ple starlark tests. PiperOrigin-RevId: 752690208
The bazel_features field objc_fragment_has_builtin_objc_strip_action doesn't exist in released versions. Use hasattr on the fragment directly.
luispadron
force-pushed
the
luis/batch-1-linking-dsym-foundation
branch
from
eb171a5 to
eb4029d
Compare
debug_symbols_partial doesn't accept executable_name - it was passed from a later cherry-pick that adds it to the partial signature.
luispadron
force-pushed
the
luis/batch-1-linking-dsym-foundation
branch
from
eb4029d to
a900529
Compare
Contributor
Author
|
hmm gonna be harder than i thought, lots of broken tests etc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batches some commits from: #2861:
debug_symbols.bzlwith upstream