Skip to content

Cherry-pick linking refactor from upstream (batch 1)#2912

Merged
luispadron merged 2 commits intomainfrom
luis/upstream-batch-1-linking-refactor
Apr 2, 2026
Merged

Cherry-pick linking refactor from upstream (batch 1)#2912
luispadron merged 2 commits intomainfrom
luis/upstream-batch-1-linking-refactor

Conversation

@luispadron
Copy link
Copy Markdown
Contributor

@luispadron luispadron commented Apr 2, 2026

Cherry-picks from the upstream branch - batch 1 of a larger sync effort (see #2861 for full context).

Commits

  • Add platform attributes to the deprecated apple_binary, allowing it to work with platform-based resolution (upstream: 0654124)
  • Refactor linking logic to use named args and consolidate variables in compilation_support.bzl and linking_support.bzl (upstream: 2507186)

No manual fixes or conflict resolution needed - clean cherry-picks.

nglevin added 2 commits April 2, 2026 00:32
… to work with the new platform-based resolution that has been added to the shared Apple linker logic.

Cherry-pick: 0654124
…s to a method are greater than one. Consolidate and reuse variables where they make sense.

Cherry-pick: 2507186
@luispadron luispadron merged commit 8e09384 into main Apr 2, 2026
11 checks passed
@luispadron luispadron deleted the luis/upstream-batch-1-linking-refactor branch April 2, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants