Run script allows empty docker_args #2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
alexeagle,
gravypod,
pcj and
smukherj1
as code owners
mindaugasrukas
suggested changes
Apr 18, 2022
Currently when using `bazel run` on a docker image, I get: ``` /[redacted].executable: line 281: docker_args[@]: unbound variable ``` Alternatively, we could just `set +u` before execing docker.
illicitonion
force-pushed
the
fix-run-script
branch
from
6a676db to
28ca2c2
Compare
Contributor
Author
|
Thanks for the review @mindaugasrukas - updated, PTAL! |
linzhp
approved these changes
Apr 19, 2022
Closed
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
Currently when using `bazel run` on a docker image, I get: ``` /[redacted].executable: line 281: docker_args[@]: unbound variable ``` Alternatively, we could just `set +u` before execing docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
bazel runon a docker image, I get:Alternatively, we could just
set +ubefore execing docker.