Added TemplateVariableInfo to rust_toolchain#1377
Merged
UebelAndre merged 1 commit intobazelbuild:mainfrom Jun 9, 2022
Merged
Conversation
36ab934 to
f023936
Compare
Contributor
|
I need to use TemplateVariableInfo provider for #1287, but this PR does not return the provider from the implementation function. This means the make variables are not substituted for rules which use the toolchain. The provider needs to be returned to allow this to work properly. For example: diff --git a/rust/toolchain.bzl b/rust/toolchain.bzl
index 90dea6e..caa3627 100644
--- a/rust/toolchain.bzl
+++ b/rust/toolchain.bzl
@@ -518,7 +518,7 @@ def _rust_toolchain_impl(ctx):
_rename_first_party_crates = rename_first_party_crates,
_third_party_dir = third_party_dir,
)
- return [toolchain]
+ return [toolchain, toolchain.make_variables]
rust_toolchain = rule(
implementation = _rust_toolchain_impl,I'll open a PR :) |
Contributor
|
See #1412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bazelbuild/bazel#14009 (comment)