Revert changes to //tools/runfiles from #722#1402
Closed
UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
Closed
Revert changes to //tools/runfiles from #722#1402UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
//tools/runfiles from #722#1402UebelAndre wants to merge 1 commit intobazelbuild:mainfrom
Conversation
illicitonion
approved these changes
Jun 13, 2022
Member
|
Could you elaborate on why it's not ideal that this function is public? I'm afraid I see existing users of this function in our codebase. |
Collaborator
Author
I have no attachment to whether or not this is public or not. I'm just trying to do due diligence in closing out all the threads on #872 (comment). If you think it's good then I'd happily close this PR. I may be misunderstanding that comment. |
Member
|
Oh I see (and wow it was my comment, I don't remember anything :) Yeah the lazy me says let's keep it public so we don't have to deal with the migration story. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of #872, some of the changes that were introduced in #722 were not ideal for the
@rules_rust//tools/runfileslibrary. This change reverts those to hopefully undo any controversial changes (see #872 (comment) for more details).