process_wrapper: Apply substitutions to param files#1565
Merged
krasimirgg merged 2 commits intobazelbuild:mainfrom Oct 13, 2022
Merged
process_wrapper: Apply substitutions to param files#1565krasimirgg merged 2 commits intobazelbuild:mainfrom
krasimirgg merged 2 commits intobazelbuild:mainfrom
Conversation
goffrie
force-pushed
the
remap-param-file
branch
from
b0f0966 to
798dc00
Compare
krasimirgg
approved these changes
Oct 13, 2022
Collaborator
krasimirgg
left a comment
krasimirgg
left a comment
There was a problem hiding this comment.
Looks good. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536. In particular, this fixes --remap-path-prefix in the presence of long command lines, preventing Bazel paths from leaking into the output.
This is essentially a rewrite of the process_wrapper changes from #1076, but it doesn't include other changes from that PR.